Refactor: reduce detekt findings (unused params, throws, long methods, config)

services/progress-service/src/main/kotlin/ru/ysu/lms/progress/ProgressController.kt

@@ -26,7 +26,6 @@ class ProgressController(
     private val service: ProgressService,
     private val publications: GradePublicationService,
     private val submissions: SubmissionService,
-    private val academic: AcademicClient,
 ) {
     @GetMapping("/me/assignments")
     fun meAssignments(
@@ -39,9 +38,7 @@ class ProgressController(
     }
 
     @GetMapping("/me/labs")
-    fun meLabs(
-        @AuthenticationPrincipal jwt: Jwt,
-    ): List<Map<String, Any>> = listOf()
+    fun meLabs(): List<Map<String, Any>> = listOf()
 
     @PostMapping("/levels")
     @PreAuthorize("hasAuthority('ROLE_ADMIN')")

services/progress-service/src/main/kotlin/ru/ysu/lms/progress/SubmissionService.kt

@@ -25,32 +25,54 @@ class SubmissionService(
         files: List<MultipartFile>,
         token: String,
     ): SubmissionDto {
-        if (files.isEmpty() || files.all { it.isEmpty }) {
-            throw BadRequestException("Приложите файлы или архив")
-        }
-        val lab =
-            runCatching { academic.getLabSummary(labId.toString(), token) }.getOrNull()
-                ?: throw NotFoundException("Лабораторная не найдена")
-        val deadline = lab.deadlineAt?.let { runCatching { Instant.parse(it) }.getOrNull() }
-        if (deadline != null && Instant.now().isAfter(deadline)) {
-            throw BadRequestException("Срок сдачи истёк")
-        }
-        val last = submissions.findFirstByStudentIdAndLabIdOrderBySeqDesc(studentId, labId)
-        val seq = (last?.seq ?: 0) + 1
-        val payload = files.mapIndexed { i, f -> (f.originalFilename ?: "file$i") to f.bytes }
-        payload.forEach { (name, bytes) ->
-            if (looksLikeProjectFile(name, bytes)) {
-                throw BadRequestException(
-                    "Файл «$name» похож на файл проекта (XML), а не на исходник. " +
-                        "Приложите файл .c/.h или zip с проектом.",
-                )
-            }
-        }
+        val payload = validatedPayload(files)
+        ensureDeadline(requireLab(labId, token))
+        val seq = nextSeq(studentId, labId)
         val stored = storage.store(studentId, labId, seq, payload)
         val entity = submissions.save(Submission(studentId = studentId, labId = labId, seq = seq))
         return toDto(entity, stored.files)
     }
 
+    private fun validatedPayload(files: List<MultipartFile>): List<Pair<String, ByteArray>> {
+        if (files.isEmpty() || files.all { it.isEmpty }) {
+            throw BadRequestException("Приложите файлы или архив")
+        }
+        return files
+            .mapIndexed { i, f -> (f.originalFilename ?: "file$i") to f.bytes }
+            .onEach { (name, bytes) -> rejectProjectFile(name, bytes) }
+    }
+
+    private fun rejectProjectFile(
+        name: String,
+        bytes: ByteArray,
+    ) {
+        if (looksLikeProjectFile(name, bytes)) {
+            throw BadRequestException(
+                "Файл «$name» похож на файл проекта (XML), а не на исходник. " +
+                    "Приложите файл .c/.h или zip с проектом.",
+            )
+        }
+    }
+
+    private fun requireLab(
+        labId: UUID,
+        token: String,
+    ): LabInfo =
+        runCatching { academic.getLabSummary(labId.toString(), token) }.getOrNull()
+            ?: throw NotFoundException("Лабораторная не найдена")
+
+    private fun ensureDeadline(lab: LabInfo) {
+        val deadline = lab.deadlineAt?.let { runCatching { Instant.parse(it) }.getOrNull() }
+        if (deadline != null && Instant.now().isAfter(deadline)) {
+            throw BadRequestException("Срок сдачи истёк")
+        }
+    }
+
+    private fun nextSeq(
+        studentId: UUID,
+        labId: UUID,
+    ): Int = (submissions.findFirstByStudentIdAndLabIdOrderBySeqDesc(studentId, labId)?.seq ?: 0) + 1
+
     @Transactional(readOnly = true)
     fun mySubmissions(
         studentId: UUID,

services/progress-service/src/main/kotlin/ru/ysu/lms/progress/domain/GradePublication.kt

@@ -21,4 +21,8 @@ class GradePublication(
 data class GradePublicationKey(
     val groupId: UUID = UUID(0, 0),
     val labId: UUID = UUID(0, 0),
-) : Serializable
+) : Serializable {
+    companion object {
+        private const val serialVersionUID: Long = 1L
+    }
+}

services/progress-service/src/main/kotlin/ru/ysu/lms/progress/domain/LabGrade.kt

@@ -23,4 +23,8 @@ class LabGrade(
 data class LabGradeKey(
     val studentId: UUID = UUID(0, 0),
     val labId: UUID = UUID(0, 0),
-) : Serializable
+) : Serializable {
+    companion object {
+        private const val serialVersionUID: Long = 1L
+    }
+}

services/progress-service/src/test/kotlin/ru/ysu/lms/progress/SubmissionServiceTest.kt

@@ -10,7 +10,6 @@ import org.springframework.mock.web.MockMultipartFile
 import ru.ysu.lms.common.BadRequestException
 import ru.ysu.lms.progress.domain.Submission
 import ru.ysu.lms.progress.repo.SubmissionRepository
-import java.nio.file.Files
 import java.nio.file.Path
 import java.util.UUID
 import java.util.zip.ZipInputStream